search

torch / cunn

Other
215 stars 174 forks source link

Fix the mix-up of height and width on depth-wise convolution #470

Closed qqning closed 7 years ago

soumith commented 7 years ago

at this rate, is this also a bug?: https://github.com/torch/nn/blob/master/lib/THNN/generic/SpatialDepthWiseConvolution.c#L199

qqning commented 7 years ago

Yes. I think so. Should I update this pr or close it? A similar fixing may be needed for the nn repos.

soumith commented 7 years ago

thanks!