small detail: `require`ing dataset-mnist gives global variable `mnist`

torch / demos

Demos and tutorials around Torch7.

355 stars 301 forks source link

Closed hughperkins closed 8 years ago

hughperkins commented 8 years ago

small detail: In https://github.com/torch/demos/blob/master/train-a-digit-classifier/dataset-mnist.lua , requireing dataset-mnist gives global variable mnist, ie named differently from the require name. I think it would be more consistent to:

either use Clement-Farabet's proposal of using pattern local foo = require 'foo'https://github.com/torch/torch7/issues/326#issuecomment-129081592 , or else
make the name of the file and the global variable match somehow

hughperkins commented 8 years ago

Since no activity on this, and cluttering up my https://github.com/issues page, and I dont use demos, I will close :-)