torch / distro

Torch installation in a self-contained folder
BSD 3-Clause "New" or "Revised" License
556 stars 484 forks source link

OpenSuSE install-deps outdated #272

Open vatrat opened 6 years ago

vatrat commented 6 years ago

In install-deps, the OS detection for OpenSuSE is outdated. The os-release checks for the name opensuse. On OpenSuSE Leap 15 (the main release, as opposed to the rolling release Tumbleweed), the ID should be opensuse-leap. On the OpenSuSE version check, it only checks if the version is 42.2. This is outdated. (For some reason, they decided to make a joke and the versioning for OpenSuSE Leap is 13 < 42 < 15. Funny, but terrible for actual use.) Changing the if logic from "use new package names if version=42.2, else use old package names" to "use old package names if (13 or below or if below 42.2), else use new package names" would work. I don't know if the .2 in 42.2 is important or not.

Changing these in the script Works For Me (tm).