torch / ezinstall

One-line install scripts for Torch.
75 stars 79 forks source link

fix multi-threaded openblas compilation #76

Closed andmarios closed 8 years ago

andmarios commented 8 years ago

A small mistake in the install-deps script (assignment instead of compare) makes openblas compile always without multi-threading support.

This is a fix.

soumith commented 8 years ago

whoops! thanks for the fix.

soumith commented 8 years ago

though, it shows here: http://tldp.org/LDP/abs/html/comparison-ops.html that you can use = or == for comparison inside a conditional in a bash script.

andmarios commented 8 years ago

You are correct. But I am on Ubuntu 15.10 (on GCE) and for some reason it didn't work with the single =. Maybe it is something else on my part.