search

torch / ezinstall

One-line install scripts for Torch.
75 stars 79 forks source link

Make install-deps die on errors #82

Closed lukeyeager closed 8 years ago

lukeyeager commented 8 years ago

It seems to me that this script should have a set -e at the top.

Every script should use set -e or check the exit status of every command. https://www.debian.org/doc/debian-policy/ch-files.html#s-scripts

I've only tested this on Ubuntu - there are bound to be more errors on other platforms.

soumith commented 8 years ago

it used to have a set -e in the past. But there were openblas issues that would randomly error out (but since openblas is optional the torch install can continue). That's the reason that I removed set -e

lukeyeager commented 8 years ago

It looks like you're dying on errors with the OpenBLAS installation anyway, right?

https://github.com/torch/ezinstall/blob/4fd8a593ce/install-deps#L19-L28

You could also add || true to the end of any lines for which you want to ignore errors.

soumith commented 8 years ago

ok i'll add back set -e and add || true to the install_openblas line