torch / optim

A numeric optimization package for Torch.
Other
197 stars 154 forks source link

Copy C1 value, in case it is a Tensor reference #127

Closed gcinbis closed 8 years ago

gcinbis commented 8 years ago

When opfunc() simply returns the output state variable of a nn model (ie. when opfunc() simply returns my_net:forward()'s output), the second opfunc() call within the for loop updates not only C2, but also C1. In this case, dC_est is wrongly 0. Avoid this behaviour by blindly copying C1 contents when it is a Tensor/CudaTensor. The overhead should be bearable as C1 is a scalar.

soumith commented 8 years ago

Thanks!