Closed nicholas-leonard closed 7 years ago
Let me know when it's ready for review =)
Reviewing. In the meantime, might be worth changing the docs because it uses rnn.Recurrent
while the code has to use nn.Recurrent
. I just noticed that and it's kind of confusing to the user.
Need to merge StepLSTM into SeqLSTM:
I am going to complete the above in another PR. This PR is already too big.
Here are the results of the benchmark:
Important lines are:
So the C version of the SeqLSTM is about 8% faster than Lua version. We can still get some more improvements by refactoring some other stuff to C and removing it from SeqLSTM, but I want to do that in another PR.