This PR contains 2 parts: (1) port to windows; (2) fix always return ByteTensor bug;
I have send the bug issue #27 . I'm not sure if the bug is due to different compiler behavior(I'm using vc), since no body reported it. However it is a reasonable behavior that different tensors are sharing the same free/retain function as long as they have no specializations. Besides, I'm sure different tensors have different functions for set1d, get1d, etc with vc since they are specializations.
I'm sure there can be different implementations to fix the bug. I am ok whether or not my way of fix is accepted as long as the bug is finally fixed in master.
soumith
commented
7 years ago
Hi,
This PR contains 2 parts: (1) port to windows; (2) fix always return ByteTensor bug;
I have send the bug issue #27 . I'm not sure if the bug is due to different compiler behavior(I'm using vc), since no body reported it. However it is a reasonable behavior that different tensors are sharing the same free/retain function as long as they have no specializations. Besides, I'm sure different tensors have different functions for set1d, get1d, etc with vc since they are specializations.
I'm sure there can be different implementations to fix the bug. I am ok whether or not my way of fix is accepted as long as the bug is finally fixed in master.
Thanks,