search

torch2424 / link-drops

A collection of your links that you find across the internet, made with the help of @julianpoy
http://linkdrops.com/#/
Apache License 2.0
2 stars 1 forks source link

Object Manipulation Instead of Re-Query #44

Closed julianpoy closed 8 years ago

julianpoy commented 8 years ago

For some reason, every time a dump was created or deleted, the backend was being queried for ALL dumps. This causes a complete refresh in the DOM, causing slow load times and high internet usage. Also drains the battery a ton, due to ~4mb download and upload every time page is refreshed.

I have changed everything to local object manipulation, which is much more sensible. Objects will now be spliced and upshifted when removing/adding to object array. This will solve the DOM reload problem, will remove the un-discovered bug of high load times and alleviate extreme backend load/crashes.

In addition, the app now doesn’t do backwards array sorting and reverse index search. Uses indexOf(dump) which limits the backwards thinking we have to do. This makes more sense.

Closes #32

Look at how fast adding links is now: untitled recording 6

julianpoy commented 8 years ago

41 Needs to be pulled in before I can complete this.

torch2424 commented 8 years ago

can this be pulled in now? #41 has been pulled

julianpoy commented 8 years ago

Nope. Now I can pull master into this, and continue this branch. Thanks!

torch2424 commented 8 years ago

You are welcome!

julianpoy commented 8 years ago

This is ready.

torch2424 commented 8 years ago

Cool Looking good dude!