search

torch2424 / link-drops

A collection of your links that you find across the internet, made with the help of @julianpoy
http://linkdrops.com/#/
Apache License 2.0
2 stars 1 forks source link

Add providers #57

Closed torch2424 closed 8 years ago

torch2424 commented 8 years ago

closes #9 closes #21

This simply updates the supported embeddable webistes as seen in the wiki: https://github.com/torch2424/link-drops/wiki/Supported-Providers

Also, I frames were really non responsive, so this has been fixed, and works much better now!

Lastly, Embedly has been removed completely to save us some cash.

HOWEVER

I may have introduced a bug, where a div needs to be clicked in order for the in-viewport to work. This may be something regarding it's css I added. As I tried removing the html and it did not fix. My computer was acting very wonky the day I discovered this. But please do not pull if the problem persists.

EDIT: This is not because of this pull request, I am actually having the problem even on the current live production at linkdrops.com. As stated above it may just be my device, however I created an issue for it: #58

julianpoy commented 8 years ago

In review

julianpoy commented 8 years ago

--- Sizing --- Youtube videos do not size properly. Instagram imbeds do not size properly. Wikipedia imbeds do not size properly. Twitter imbeds do not size properly. Gist imbeds do not size properly. Kickstarter imbeds do not size properly. --- Claimed to work in Wiki --- Amazon imbeds do not show up. Vine imbeds do not show up. Vimeo imbeds do not show up. Spotify imbeds do not show up. --- Used to work, now broken --- Soundcloud imbeds are no longer working.

Looks like this pull is far from ready, or the wiki should be updated. Either one.

torch2424 commented 8 years ago

@julianpoy

--Sizing-- I thought they looked fine being portrait, but I'll go and add css for them individually to fix that.

--Claimed to work in Wiki--

Are you sure it's not because of what I said in my OP.I tested all of these right now, and they all worked beautiful. Note for ones that did not start in the viewport, I had to click the link, and then go back for them to show up. It is a bug that is not because of this branch that was introduced into master, can needs to be fixed.

--Used to work, now broken --

Again, see the OP. I tested this working just fine.

P.S If you are refferring to any of the embeds being cut off, I can add a border for them. As some of the mebeds will display ALOT of content, so I added a max height and width to make things manageable

P.S.S Vine got blocked from no embed it seems. I tested it working before, But I think they just wanted to make me look dump :p My apologies on that one

P.S.S.S Vimeo acidentally became vine twice. That one was entirely my bad. My apologies

Last P.S Just spent the last hour re-testing, Again, please notice the bug I posted. Everything shall be fine and I will comment when I finishing styling

torch2424 commented 8 years ago

Finished now is EXCELLENT to pull in . EXTENSIVELY tested on my end. going to work on that bug now, in a new branch

torch2424 commented 8 years ago

I fixed the bug I am referring to in another branch. twas a super easy fix, and I'll do the offest thingy you wanted while I am at it :)

Actually for the offset i'll need the branches to be pulled in

See #59 for the bug fix

julianpoy commented 8 years ago

59 has been merged. Can you pull master into this branch, so that I can retest and verify all is well?

I want to make sure the bug I experienced isn't still lurking somewhere.

torch2424 commented 8 years ago

Pulled in yo!

julianpoy commented 8 years ago

Coolio. Will check this out and pull in if it works :)

julianpoy commented 8 years ago

--- Sizing --- Youtube videos do not size properly. --- Claimed to work in Wiki --- Amazon imbeds do not show up. Spotify imbeds do not show up. --- Used to work, now broken --- Soundcloud imbeds are no longer working.

An example containing all that are broken: https://www.dropbox.com/s/ofg034lxrxnwd66/Screenshot%202015-09-20%2009.34.35.png?dl=0

torch2424 commented 8 years ago

@julianpoy We are going to have to do this in person. I tested this for like 2 hours, and got everything working. something is up with your machine, everything wors on all of mines. And I dont quite understand what's wrong with the youtube size

julianpoy commented 8 years ago

Did you see the screenshot?

julianpoy commented 8 years ago

These are the links I used: https://soundcloud.com/oftheothertime/moments-in-takyon https://open.spotify.com/track/18sbrkncm1bTPAv2pzsVGM http://www.amazon.com/Schleich-14601-Giant-Turtle/dp/B001O2QW9G/ref=sr_1_1?ie=UTF8&qid=1442766332&sr=8-1&keywords=turtle https://www.youtube.com/watch?v=A_7phE0RtbU

torch2424 commented 8 years ago

The soundcloud song can't be embedded period. If you try soundcloud doesnt allow you, did you perhaps turn off embedding for that song?

torch2424 commented 8 years ago

Yes I saw the screenshot. Could you please explain to me the youtube thingy? and the spotify did work, just with play.spotify, not open.spotify, so I'll add that too

torch2424 commented 8 years ago

I wanted to avoid using just amazon.com/ , so I did some more deep linking, but you seemed to find a place where you can avoid /gp/product.

julianpoy commented 8 years ago

Most products I just looked at dont use /gp/product. Perhaps because Im using prime?

julianpoy commented 8 years ago

As for youtube: the box is far off-center

torch2424 commented 8 years ago

@julianpoy perhaps, but everything should be fixed now!

torch2424 commented 8 years ago

Yo, added some more centering to the youtube thing. but honestly, I cant replicate it

julianpoy commented 8 years ago

I notice that you replaced play.spotify.com with open.spotify.com. We need to handle both.

julianpoy commented 8 years ago

Honestly we need to be able to detect a lot of possibilities. We are going to be putting it out to users who will not be careful about what they paste

torch2424 commented 8 years ago

It does handle both. the code is currently:

<div class = "embed"
            ng-if = "(dump.content.indexOf('https://play.spotify.com/') > -1)
                || (dump.content.indexOf('https://open.spotify.com/') > -1)"
torch2424 commented 8 years ago

and I got the youtube thing, its the card size that's acting weird with the column thingy

julianpoy commented 8 years ago

I fixed it.

torch2424 commented 8 years ago

NOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO

torch2424 commented 8 years ago

I made width auto hahaha

julianpoy commented 8 years ago

Width auto will inherit width 90%, therefore duplicated code

julianpoy commented 8 years ago

Whats up with soundcloud?

torch2424 commented 8 years ago

okay cool. Well is everything working for you?

torch2424 commented 8 years ago

screenshot from 2015-09-20 11 33 11

Does your song settings match this? I think that song cant be embedded because when you uploaded the song, you didnt want people to be able to embed it

julianpoy commented 8 years ago

The thing is, on master, my song embeds.

torch2424 commented 8 years ago

Okay, then we're going to have to use the soundcloud api then. Right now I'm doing homework, I'll switch it back to the soundcloud api from master

julianpoy commented 8 years ago

Oh gotcha, sounds good.

torch2424 commented 8 years ago

I switched back to the soundcloud api to make your song work <3

julianpoy commented 8 years ago

Woo!