search

torch2424 / link-drops

A collection of your links that you find across the internet, made with the help of @julianpoy
http://linkdrops.com/#/
Apache License 2.0
2 stars 1 forks source link

Improve App Performance #89

Closed torch2424 closed 8 years ago

torch2424 commented 8 years ago

Been starting at the code, and followed a couple of guides on how to improve performance in angular apps, specifically this one: http://www.alexkras.com/11-tips-to-improve-angularjs-performance/

Speeds things up a tiny bit, but it's nice!

julianpoy commented 8 years ago

Yo, couple things on this. First off, I removed track by a while ago, because the way we are adding and removing elements in a local scope, track by actually slows things down. Track by uses a local unique id vs angular generating its own. For our purposes, its better to have angular generate it.

I like the one-time bindings! Those are great... Except for labels. Labels need two way binding to work with their sort functions and adding/removal.

Otherwise, dope pull! :dart: on target

torch2424 commented 8 years ago

Yo But I think track by does the weird finding where all the elements disappear like a machine gun. Can you confirm that?

And I dont see why using track by would affect adding and deleting int the local scope. but my main point is above.

And fashow I didnt relaize I did that, I did it super fast

torch2424 commented 8 years ago

Removed watchers on labels. And track by does not do the weird machine gun disappearing, but I find no track by to be actually a bit slower on my end, I was switching back and forth, and track by dump._id was working great for me

torch2424 commented 8 years ago

Stopwatched several things compared between track by and not track by, track by always felt a little faste, and stop watched show it to be slightly faster

torch2424 commented 8 years ago

Ill remove track by

julianpoy commented 8 years ago

<3

torch2424 commented 8 years ago

removed track by

torch2424 commented 8 years ago

Yo I want to avoid conflicts and from what i could tell, track by was your last issue with this branch, going to pull it in. Please odnt blow me up one day in the future for this self pull <3

julianpoy commented 8 years ago

:'( I came here to do it for you <3

torch2424 commented 8 years ago

@julianpoy I'm sorry selfie-0