search

torch2424 / wasmboy

Game Boy / Game Boy Color Emulator Library, 🎮written for WebAssembly using AssemblyScript. 🚀Demos built with Preact and Svelte. ⚛️
https://wasmboy.app/
GNU General Public License v3.0
1.39k stars 65 forks source link

LCDC should be initialised with BG on #353

Closed tkers closed 2 years ago

tkers commented 2 years ago

I noticed that the LCDC register (0xFF40) is initialised to 1001 0000, which means the background (bit 0) is not enabled by default.

It is my understanding that the correct value on startup should be 1001 0001 instead. At least, when testing on a physical device (and a bunch of emulators), background rendering has always worked for me without touching the LCDC register.

torch2424 commented 2 years ago

Yoooo! Thank you so much for finding and reporting this! 😄 I haven't had much time to work on the emulator as of late, but that's a super simple fix, so maybe after my next concert I'm doing, I'll go ahead and open a PR for that real quick! 😄 Thank you! 🙏🏾

tkers commented 2 years ago

I actually didn't realise you hadn't worked on this emulator for a while when I opened this issue 😄 Anyway, I had some time and managed to find where the initialisation happens and created a PR for this ☝️

torch2424 commented 2 years ago

This should be published in 0.7.1 😄 🎉