torchbox / careers

Torchbox careers site
https://torchbox.com/careers
4 stars 1 forks source link

404 when accessing old job posts (due to caching?) #101

Closed thibaudcolas closed 1 year ago

thibaudcolas commented 1 year ago

Reports from users – there are job post URLs 404ing upon access, even though the posts are long-existing.

Seems like this could be an issue with our bespoke caching of job posts: https://github.com/torchbox/careers/blob/main/pages/api/_peopleHR.ts

jhancock532 commented 1 year ago

This issue has been addressed in the following MR by @Morsey187: https://github.com/torchbox/careers/pull/104

Morsey187 commented 1 year ago

Just to clarify, I believe this has been fixed/resolved already as part of this PR #103 (see PR description), #104 is more of a tidy-up PR to reduce technical debt.

Morsey187 commented 1 year ago

Resolving this issue based on testing #103 and the comment above