search

torchbox / careers

Torchbox careers site
https://torchbox.com/careers
4 stars 1 forks source link

#67 - Life @ Torchbox Page - Values Carousel #37

Closed jhancock532 closed 2 years ago

jhancock532 commented 2 years ago

Link to Ticket on Codebase.

This is a react swiper carousel implementation, but I'm having difficulty with correctly setting the slidesPerView value to feature one card at a time (across mobile and desktop). The issue seems to be caused by the carousel slides not rendering correctly - I've added inline to all the carousel slides as they are rendering one on top of the other instead of one after the other, but inline seems to break the slidesPerView. I set the carousel width to max-content to hold all the slides on one line, but I don't think this is the right implementation. There's probably an error with my use of <SwiperSlide> but I can't find it - this implementation is based off another project which runs fine.

jhancock532 commented 2 years ago

I've fixed the issue with the missing styles and polished the implementation. I've added a link to view the images in fullscreen, as these images contain text that is hard to read - I will get design review before merging, we might decide not to add a link here and include further details on values in a written section directly below this carousel. This would make the content more accessible and less likely to be scrolled past.

jhancock532 commented 2 years ago

After confirming with Ben, the link to the image was removed and text section beneath the value cards added.