#74 - Job Listing Title Section

torchbox / careers

Torchbox careers site

https://torchbox.com/careers

4 stars 1 forks source link

#74 - Job Listing Title Section #45

Closed jhancock532 closed 2 years ago

jhancock532 commented 2 years ago

Link to ticket on Codebase.

I was unable to test the whether the share link operates as a mailto: link correctly on desktop devices. My mac currently crashes every time I try to sign into the mail app, and debugging tutorials haven't helped me fix this issue.

I'm not sure about my refactoring of the button component, there is some reuse of code to support internal and external links which is a bit awkward.

Live preview & link for testing.

jhancock532 commented 2 years ago

Fixed email client issues, share link now shows the following when you click it on desktop.

jhancock532 commented 2 years ago

I've made some changes that affect how I load and resize svg files, it would be good to get further review on this