torchbox / careers

Torchbox careers site
https://torchbox.com/careers
4 stars 1 forks source link

Refactor Containers Following TBX.com Grid System #88

Closed jhancock532 closed 2 years ago

jhancock532 commented 2 years ago

Raised during design review with Ben Enright. Now the menu navigation follows the 8.33vw, 16.66vw grid system it would be great to line the rest of the content up to follow this system as well.

Description of Changes Made

I've updated most of the text containers to follow the design system on tbx.com (8.33vw margin on mobile, 25vw margin on desktop). In some cases I've avoided following the original designs to make changes to match the grid system. The changes are generally in line with the designs, within 50 pixels or so.

I've not updated the life at torchbox page yet as this didn't break when I updated the site layout - I can return to this in another MR.

How to Test

Thorough testing of all pages across the site is required, across all device sizes. Apologies for the large number of file changes, it would have been better to make a few MRs to an integration branch instead here. Happy to cherry pick the commits into individual MRs if this helps.

MR Checklist

jhancock532 commented 2 years ago

I've fixed the mobile menu button in another MR that's just been merged into this one 👍 I've fixed the margin on the academy day cards.

Having 3.5vw on the footer looks a lot better and is closer to the designs, I think I will stick with this.