search

torchbox / django-pattern-library

UI pattern libraries for Django templates
https://torchbox.github.io/django-pattern-library/
BSD 3-Clause "New" or "Revised" License
368 stars 46 forks source link

Pattern library does not load CSS or JavaScript in IE11 #151

Closed helenb closed 2 years ago

helenb commented 3 years ago

Issue Summary

If you view the pattern library in IE11 (tested with browserstack) it does not load the CSS and JS. The console is reporting a syntax error

Steps to Reproduce

  1. Open a new session of IE11 in Browserstack
  2. Visit a pattern library page

Screenshot 2021-07-23 at 13 35 12

Any other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?

Technical details

Tested on wagtail-kit which is using pattern library version 0.3.0 Tested on action for children which is using pattern library version 0.5.0

The console reports a syntax error but it is hard to see what this is in the compiled and compressed code: Screenshot 2021-07-23 at 14 18 09 Screenshot 2021-07-23 at 14 17 59

zerolab commented 2 years ago

I think it is high time we stopped supporting IE11, no?

thibaudcolas commented 2 years ago

PR to fully remove support: https://github.com/torchbox/django-pattern-library/pull/162

We still have a lot of projects with IE11 support targets, so I think it’s important individual patterns can still be rendered correctly in IE11, but the pattern library UI doesn’t have to support it.