torchbox / django-pattern-library

UI pattern libraries for Django templates
https://torchbox.github.io/django-pattern-library/
BSD 3-Clause "New" or "Revised" License
360 stars 44 forks source link

Fix tag overrides’ default_html preventing real tag usage #199

Open thibaudcolas opened 2 years ago

thibaudcolas commented 2 years ago

Description

This fixes a bug with our tag overrides’ support for default values. As implemented currently, we can no longer just let the tag render as normal – the default value would always take precedence, even if unset.

Even though this is a bug fix, I believe it might be sensible to only release this in a major version. Lots of projects might rely on the fact that tags always render None.

Checklist

cclauss commented 7 months ago

This branch has conflicts that must be resolved.