torchbox / django-pattern-library

UI pattern libraries for Django templates
https://torchbox.github.io/django-pattern-library/
BSD 3-Clause "New" or "Revised" License
360 stars 44 forks source link

Jinja templates #206

Open gone opened 1 year ago

gone commented 1 year ago

Description

This is a first pass at jinja support.

Right now this supports the major features I can account for, outside of overriding extends and includes tags.

I haven't really checked against the styleguide/updated documentation/tests so I think this is just in wip status

Fixes # (issue) #171

Checklist

gone commented 1 year ago

We got overriting the extends and includes tags working, so I think this is ready for review!

thibaudcolas commented 1 year ago

Omg! Thank you @gone, I’ll find some time to review this properly.

gone commented 1 year ago

Cool yeah, happy to make any changes!

maribedran commented 8 months ago

@gone I opened a PR to your branch fixing some issues, but I could also open a new one directly here if it's easier for @thibaudcolas to review the entire thing at once. Let me know what you folks prefer.

cclauss commented 7 months ago

@gone Given that #171 is closed, please rebase this PR.

CuriousLearner commented 4 months ago

Hey @gone 👋🏼

I've opened up a PR to your repo here: https://github.com/gone/django-pattern-library/pull/6

@thibaudcolas If it's easier, I can open it up directly on the Torchbox upstream. Please let me know what you folks would prefer.

Many thanks! 🙌🏼