search

torchbox / django-pattern-library

UI pattern libraries for Django templates
https://torchbox.github.io/django-pattern-library/
BSD 3-Clause "New" or "Revised" License
360 stars 44 forks source link

ci: using tox_install.sh doesn't seem highly conventional. Can switch to a different way? #221

Open simkimsia opened 1 year ago

simkimsia commented 1 year ago

Is your proposal related to a problem?

While trying to solve #212, i discover issues when trying to upgrade the tox.ini which was using whitelist_internals, a deprecated keyword.

Sent me on a tangent and wrote a drastically different way in PR #219

In order to adopt more conventional ways of using both tox with poetry, shall we try a different way?

Issues related: #214, #215, #216, #218

Describe the solution you'd like

219 removes tox_install.sh and tool.poetry.dev-dependencies in pyproject.toml altogether in favor of using tool.poetry.extras instead.

Another alternative is to use https://pypi.org/project/tox-poetry-installer/

bcdickinson commented 1 year ago

Hi @simkimsia, tox_install.sh is relic from before I knew tox-poetry existed. As that project is now deprecated in favour of Poetry's built-in support, I think the way forward here is to follow the Poetry docs and drop tox_install.sh.

PS - thanks for showing an interest in this project and submitting issues and PRs, I'll try and get round to reviewing them as soon as I can!

simkimsia commented 1 year ago

Thank you @bcdickinson

Lmk how I can help