Upgrade/36-crispy-forms-gds

torchbox / tbxforms

A Torchbox-flavoured template pack for django-crispy-forms, adapted from crispy-forms-gds.

https://pypi.org/project/tbxforms/

BSD 2-Clause "Simplified" License

6 stars 5 forks source link

Upgrade/36-crispy-forms-gds #39

Closed lparsons396 closed 1 year ago

lparsons396 commented 1 year ago

The following merged PRs to crispy-forms-gds can be pulled into our package:

https://github.com/wildfish/crispy-forms-gds/pull/59
1. https://github.com/wildfish/crispy-forms-gds/pull/76:
  - we will need to check the CSS class name for the divider markup
  - see https://design-system.service.gov.uk/components/radios/ - the divider should be used to separate answers that are conceptually different

lparsons396 commented 1 year ago

(I'm just fixing the failing tests now)

jams2 commented 1 year ago

For the failure here, it looks like the issue is linebreaks in the wrong place in the fixture (this line and this line). I would compare what's returned by parse_form and parse_contents on this line.

It's one of the cumbersome things about this project that we are testing against so many html fixtures. Maybe Django provides a way to do less-whitespace-sensitive comparison of html?

kbayliss commented 1 year ago

This work has been merged as part of https://github.com/torchbox/tbxforms/pull/52 (it was easier to do within an integration branch due to so many related changes)