torchbox / tbxforms

A Torchbox-flavoured template pack for django-crispy-forms, adapted from crispy-forms-gds.
https://pypi.org/project/tbxforms/
BSD 2-Clause "Simplified" License
6 stars 5 forks source link

Test suite does not use the correct `BaseForm` #44

Closed kbayliss closed 1 year ago

kbayliss commented 1 year ago

The tbxforms package defines a BaseForm that you would inherit from to use tbxforms in a given project: https://github.com/torchbox/tbxforms/blob/main/tbxforms/forms.py#L14

However, this isn't used for our tests - they define their own BaseForm - https://github.com/torchbox/tbxforms/blob/main/tests/forms.py#L12 - which undermines the entire test suite.

The test suite should at least inherit from the same base form class, even if additional changes are required to run the tests.

(Originally raised by @balazs-endresz here 🙌🏻)