torchbox / tbxforms

A Torchbox-flavoured template pack for django-crispy-forms, adapted from crispy-forms-gds.
https://pypi.org/project/tbxforms/
BSD 2-Clause "Simplified" License
6 stars 5 forks source link

Remove the nested styling from tbxforms components #49

Closed helenb closed 1 year ago

helenb commented 1 year ago

This means that when styles for tbxforms components are being updated in projects, we don't have nested styling to override. See https://github.com/torchbox/tbxforms/issues/40

Note that due to not currently having a local set-up where I can test this, this will need testing as well as code-reviewing.

helenb commented 1 year ago

I see that the test_python CI process has failed, but just to clarify this should be unrelated to my changes, which are only to CSS

jams2 commented 1 year ago

Looks like we need to bump the poetry version (https://github.com/python-poetry/poetry/issues/7878)

helenb commented 1 year ago

@kbayliss I see there's some activity happening on tbxforms at the moment. I don't have a local build any more (it was on my old laptop) - if you have a sec could you rebase and test this branch? It failed tests due to the poetry version but that must be fixed now if other branches are passing. thanks!

kbayliss commented 1 year ago

@helenb yep! I'll make sure it gets added to the release

helenb commented 1 year ago

@helenb yep! I'll make sure it gets added to the release

Thank you!

kbayliss commented 1 year ago

This work has been merged as part of https://github.com/torchbox/tbxforms/pull/52 (it was easier to do within an integration branch due to so many related changes)