Support for wagtail42 - Githubissues

torchbox / wagtail-footnotes

MIT License

20 stars 18 forks source link

Support for wagtail42 #48

Closed nickmoreton closed 1 year ago

nickmoreton commented 1 year ago

This adds support for the latest Wagtail (v4.2)

It also adds/changes:

I did some work to add tests a little while ago and have merged that work here. https://github.com/torchbox/wagtail-footnotes/pull/46
Remove code changes that added support for wagtail versions < 4.1
Moved the tests outside of the package.

katdom13 commented 1 year ago

Hi @nickmoreton , This LGTM. Thank you!

jsma commented 1 year ago

Should this PR be updated to support Wagtail 5.0 or is a new PR required? Please let me know how I can help move this forward.

zerolab commented 1 year ago

Thank you for the offer @jsma, I would suggest a new PR for 5.0 One way to help is review/test locally so we can progress it.

@kevinhowbrook how are you with time? Will you have a chance to look at this this week? if not I can try to look over the weekend to help move things along

zerolab commented 1 year ago

closing in favour of #49 (which incorporates it)