It seems like Ruff versions used for linting in local development and in the pipeline are inconsistent. This leads to issues with formatting that aren't picked up by pre-commit, which runs on the local ruff, but cause the pipeline to fail.
The ruff version in tests/requirements.txt is ruff==0.0.287.
Ruff in the .github/workflows/ruff.yml workflow is installed as python -Im pip install --user ruff, which I believe installs the newest compatible version of ruff.
I think it would be beneficial to upgrade to the newest release of ruff (v0.4.4) and make sure that this is consistent between the requirements and the pipeline.
zerolab
commented
1 month ago
It seems like Ruff versions used for linting in local development and in the pipeline are inconsistent. This leads to issues with formatting that aren't picked up by
pre-commit, which runs on the local ruff, but cause the pipeline to fail.The ruff version in
tests/requirements.txtisruff==0.0.287.Ruff in the
.github/workflows/ruff.ymlworkflow is installed aspython -Im pip install --user ruff, which I believe installs the newest compatible version of ruff.This leads to ruff check failing on PRs like https://github.com/torchbox/wagtail-grapple/pull/374
I think it would be beneficial to upgrade to the newest release of ruff (v0.4.4) and make sure that this is consistent between the requirements and the pipeline.