search

torchbox / wagtail-grapple

A Wagtail app that makes building GraphQL endpoints a breeze!
https://wagtail-grapple.readthedocs.io/en/latest/
Other
152 stars 57 forks source link

Confusing docstring in PageInterface #69

Closed leewesleyv closed 4 years ago

leewesleyv commented 4 years ago

The docstring of resolve_children() reads: "Resolves a list of live children of this page with show_in_menus set." (I guess this is the source of the docstring). The function however, does not filter live child pages, nor does it filter on show_in_menus.

I wouldn't mind making a PR to resolve this issue, but I don't know if this function should be returning live pages only (filtering for show_in_menus does not make sense here IMO).

Is the docstring or the query invalid?

Useful links:

zerolab commented 4 years ago

Thank you for this. Fixed in c0932f2. The docstring was erroneous