search

torchbox / wagtail-markdown

Markdown support for Wagtail
zlib License
198 stars 66 forks source link

Wagtail 6.0 depreciates the WidgetWithScript hook #138

Closed byhill closed 9 months ago

byhill commented 9 months ago

With the release of Wagtail 6.0, the use of WidgetWithScript is now depreciated.

Currently, wagtail-markdown still uses it for it's MarkdownTextArea class here.

This caused the warning for my Wagtail project once I upgraded the wagtail version from 5.* to 6.0. RemovedInWagtail70Warning: The usage of `WidgetWithScript\` hook is deprecated. Use external scripts instead.

I'm currently using version 0.11.1 of wagtail-markdown.

twn39 commented 9 months ago

It seems that this issue has been resolved through a PR, but a new version has not been released yet.

twn39 commented 9 months ago

I have encountered the same issue. Could the team release a new version promptly?

zerolab commented 8 months ago

https://github.com/torchbox/wagtail-markdown/releases/tag/v0.12.0

RemovedInWagtail70Warning is a warning, which while annoying, it doesn't break anything. And you can silence specific warnings in your project quite easily - https://stackoverflow.com/questions/879173/how-to-ignore-deprecation-warnings-in-python#879249

I would like to point out that the "team" is a single person. So, you know, have a bit of patience. What would really help, is to either to submit a PR with a fix, or review and test any open PRs with a fix so as to speed things up.

twn39 commented 8 months ago

@zerolab I'm very sorry if my tone came across as pushy, I didn't mean to rush you and I appreciate you developing this plugin, it has helped me a lot.

zerolab commented 8 months ago

Thank you @twn39