torchbox / wagtail-wordpress-import

A package for Wagtail CMS to import WordPress blog content from an XML file into Wagtail
MIT License
44 stars 16 forks source link

Allow image id to fail #143

Closed fabienheureux closed 2 years ago

fabienheureux commented 2 years ago

Allow image download without scheme and external domain

If images have an url like //example.com/image.jpg, the imported url does not care about the domain and prepend the wagtail domain, hence leading to a 404 when downloading the image


codecov-commenter commented 2 years ago

Codecov Report

Merging #143 (99bf46e) into main (e6f6e41) will decrease coverage by 0.04%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   65.05%   65.01%   -0.05%     
==========================================
  Files          32       32              
  Lines        1265     1269       +4     
  Branches      228      228              
==========================================
+ Hits          823      825       +2     
- Misses        400      402       +2     
  Partials       42       42              
Impacted Files Coverage Δ
...l_wordpress_import/prefilters/handle_shortcodes.py 96.00% <50.00%> (-4.00%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e6f6e41...99bf46e. Read the comment docs.

fabienheureux commented 2 years ago

:man_facepalming:

wrong branch.