search

torchbox / wagtail-wordpress-import

A package for Wagtail CMS to import WordPress blog content from an XML file into Wagtail
MIT License
44 stars 16 forks source link

Should/can we pass around strings rather than soup objects? #67

Open nickmoreton opened 3 years ago

nickmoreton commented 3 years ago

The first time we get some soup is with the lxml parser.

Are you saying that the soups are different because one uses lxml and another uses html.parser? If so, then that's a strong argument for passing around string HTML objects instead of soup instances.

I favour readability and consistency at this stage, especially as we aren't yet aware of any performance concern.

_Originally posted by @nimasmi in https://github.com/torchbox/wagtail-wordpress-import/pull/57#discussion_r740372692_