torchbox / wagtail-wordpress-import

A package for Wagtail CMS to import WordPress blog content from an XML file into Wagtail

MIT License

44 stars 16 forks source link

Add a change log #95

Closed nickmoreton closed 2 years ago

nickmoreton commented 3 years ago

Add a change log

This adds a change log generated with https://github.com/github-changelog-generator/github-changelog-generator

Ticket URL: https://projects.torchbox.com/projects/wordpress-to-wagtail-importer-package/tickets/61

Testing
- [x] CI passes
- [x] These changes do not reduce test coverage
Documentation.
- [x] This PR adds or updates documentation

nimasmi commented 2 years ago

I like the idea of a generated CHANGELOG.md, but…

this one looks like the output is often quite messy
will it require us to use Conventional Commits https://www.conventionalcommits.org/en/v1.0.0/? We haven't been.
how does it work with version numbering?
it seems to pick up on issues addressed only when you use GitHub issues as your ticket tracker

Have I got that right?

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@644444a). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage        ?   65.05%           
=======================================
  Files           ?       32           
  Lines           ?     1265           
  Branches        ?      228           
=======================================
  Hits            ?      823           
  Misses          ?      400           
  Partials        ?       42

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 644444a...f212a8c. Read the comment docs.

nickmoreton commented 2 years ago

Hi @nimasmi I just altered the way to keep a CHANGELOG to not use the automated way.