Chooser buttons not visible on hover with wagtail 4.0.2

torchbox / wagtailmedia

A Wagtail module for managing video and audio files within the admin

https://pypi.org/project/wagtailmedia/

BSD 3-Clause "New" or "Revised" License

232 stars 70 forks source link

Chooser buttons not visible on hover with wagtail 4.0.2 #175

Closed th3hamm0r closed 1 year ago

th3hamm0r commented 1 year ago

Issue Summary

This has worked with wagtail 4.0.1: wagtailmedia_chooser_wagtail4 0 2

Related: #173

Steps to Reproduce

Start the interactive test with tox -re interactive ("-r" to clear any existing venv with an old wagtail)
Login and go to http://0.0.0.0:8020/admin/pages/add/wagtailmedia_tests/eventpage/2/
Add a related media and then find those invisible buttons

Technical details

Python version: 3.10
Django version: 4.1.1 (tox interactive), 3.2 (actual deployment)
Wagtail version: 4.0.2
wagtailmedia version: 0.11
Browser version: Firefox 105

zerolab commented 1 year ago

Uff, I wonder what changed. Note to self: #172 addressed a similar thing before

th3hamm0r commented 1 year ago

@zerolab sry, didn't have the time to search for the reason initially, but now I've tried a bit and it seems like this change https://github.com/wagtail/wagtail/commit/44d954e00a6f894eb6951f9fcbb9285a0bf1946b could be the cause. I've also found the issue for custom choosers based on the new helper classes in wagtail 4. I will open an issue there.

zerolab commented 1 year ago

Fixed in e7b333f

th3hamm0r commented 1 year ago

Thx for the fix, but actually it shouldn't be necessary to fix it for every custom chooser (like for wagtailmedia), I think it should be fixed in wagtail: https://github.com/wagtail/wagtail/issues/9260

zerolab commented 1 year ago

I know, this is a case where I don't want to wait for core. will remove once that if fixed by doing another patch release