search

torchbox / wagtailmedia

A Wagtail module for managing video and audio files within the admin
https://pypi.org/project/wagtailmedia/
BSD 3-Clause "New" or "Revised" License
224 stars 70 forks source link

Wagtail 4.2 upgrade #193

Closed katdom13 closed 1 year ago

katdom13 commented 1 year ago

Suppressed warnings during test, added Wagtail 4.2 to test matrix in tox.ini

zerolab commented 1 year ago

@katdom13 I don't have the time to look now, but I suggest dropping support for Wagtail < 4.1, if you have not done that yet.

I have a branch that started that process: https://github.com/torchbox/wagtailmedia/tree/4.1%2B

katdom13 commented 1 year ago

Some checks fail, but these were failing prior to this MR.

katdom13 commented 1 year ago

Hi @zerolab , I would like to request for a re-review. I also included commits from your branch, 4.1+.

Thank you!

katdom13 commented 1 year ago

Hi @zerolab , I think I managed to fix the tests: https://github.com/torchbox/wagtailmedia/pull/193/commits/c89e3a594a77bf924ed78bf26f156e7a26d2c1eb https://github.com/torchbox/wagtailmedia/pull/193/commits/9264117fc895e4099cd6f3917d542814728844c0

zerolab commented 1 year ago

Thank you very much for this @katdom13