search

tordanik / OSM2World

converter that creates three-dimensional models of the world from OpenStreetMap data
http://osm2world.org/
GNU Lesser General Public License v3.0
562 stars 124 forks source link

building:roof with min_level not supported #57

Open HolgerJeromin opened 11 years ago

HolgerJeromin commented 11 years ago

I built the ways http://osm.org/browse/way/215433273 and http://osm.org/browse/way/84159471 they are not rendered as expected. I think it is related to the combination of building = roof and building:min_level = xy

http://commons.wikimedia.org/wiki/File:Aachen_RWTH_IBAC_2.jpg is a photo of this roof construction. The walls are not in osm till now. Thanks for your work!

hjanetzek commented 11 years ago

I'm not the developer. anyway I looked at your example and one problem seems to be the three nodes north-east of the roof that are no connected to the building outline. The used algorithm produces arbitrary results when the point is exactly on the line. so better always make sure to have your nodes connected. This issue could often be handled automatically is osm2world by merging co-linear segments I guess. I've committed the required change to the building now. BTW it helps to debug by settings roof:colour on the part you want test to show up

HolgerJeromin commented 11 years ago

You are refering to the problem from https://github.com/tordanik/OSM2World/issues/56 ? This ways of this issue have no building:part

hjanetzek commented 11 years ago

you are right. my comment was regarding #56

tordanik commented 11 years ago

building:min_level currently only works if building:levels is also being used. It isn't related to building=roof except for the probability of mappers using this tag combination.