search

torgeadelin / react-native-animated-nav-tab-bar

A simple and customisable React Native component that implements an animated bottom tab bar for React Navigation.
MIT License
889 stars 102 forks source link

The library needs to move @react-navigation/native to peerDependencies. #109

Closed khelifioussama closed 2 years ago

khelifioussama commented 2 years ago

This is a problem in the react-native-animated-nav-tab-bar package. It adds @react-navigation/native to its dependencies which makes it possible to include multiple versions of @react-navigation/native since you will also have it in your own package.json, and multiple versions of @react-navigation/native will cause such issues:

https://github.com/torgeadelin/react-native-animated-nav-tab-bar/blob/0642630cb487a496b0619201daa68cdd164f8f14/package.json#L59

The library needs to move @react-navigation/native to peerDependencies.

It also does the same for react-native-screens, it's in dependencies whereas it should be in peerDependencies.

torgeadelin commented 2 years ago

Please update to the latest version, this should be fixed now.