torgeadelin / react-native-animated-nav-tab-bar

A simple and customisable React Native component that implements an animated bottom tab bar for React Navigation.
MIT License
889 stars 102 forks source link

feat(upgrade): add support to navigation v6 #115

Closed torgeadelin closed 2 years ago

torgeadelin commented 2 years ago

Description

This is some initial work to make the library compatible with react-navigation v6. I have tested this and seems to be working fine with v6. The current release also seems to work, these changes only make some prop nam changes.

Important

Before testing these changes, or even the current release with v6 please make sure you install v6 properly first, and then try to use this library. Here's some docs to help with that:

afkcodes commented 2 years ago

will use the v6 branch and test it out, thanks @torgeadelin

afkcodes commented 2 years ago

Hey @torgeadelin i tried this with react navigation6 the navigation-v6-support branch but it was giving me error.

torgeadelin commented 2 years ago

@afkcodes make sure to install the react navigation requirements correctly before, remove all node_modules, clear cache, and then install this branch's version. I recommend doing it via npm pack which will generate a zip folder that can then be installed with npm install path/to/file.zip. Hope this helps!

jenkijo commented 2 years ago

Everything look good, when will you merge it?

Sudhir9026 commented 2 years ago

I am unable to save master branch when you are going to provide support to v6?

github-actions[bot] commented 2 years ago

Stale pull request message

c-fitzmaurice commented 1 year ago

Other than GitHub actions closing this, any reason why v6 support was not released? Would love to use this in an Expo application.

torgeadelin commented 1 year ago

As I've mentioned above, the existing version seems to be compatible with v6 already. The changes in this PR fixes some minor bugs.

torgeadelin commented 1 year ago

I'll try to merge this soon. It would be great if more people can test everything works with v6 tho.