torgeadelin / react-native-animated-nav-tab-bar

A simple and customisable React Native component that implements an animated bottom tab bar for React Navigation.
MIT License
902 stars 101 forks source link

Still rerendering problem. #41

Closed cgarcia55 closed 4 years ago

cgarcia55 commented 4 years ago

i'm still facing the issue with the re-rendering problem, there is a configuration or props that im missing? Every tab change, the active tab re-render, so when i go back, re-render as well

torgeadelin commented 4 years ago

Did you update to 3.0.4?

cgarcia55 commented 4 years ago

"react-native-animated-nav-tab-bar": "^3.0.4",, yes, yes that's the weird thing

kristoff2016 commented 4 years ago

Hi, what is the issue with re-rendering?

cgarcia55 commented 4 years ago

every change of tabs, re-render the active tab. If navigate from home to cart and then go back to home, i have to wait Home finish de render.

torgeadelin commented 4 years ago

I'll have a look today. It's weird because I pushed a fix on Sunday 🤔

torgeadelin commented 4 years ago

I just tested again, and it seems to work for me. I'm testing on iOS 14, with React native 0.63. Please delete your node_modules and run the local server with react-native start --reset-cache. The component is initialised only once.

Try to run the example project from the repo and see if it works there. Add a component did mount to one of the screens and check.

cgarcia55 commented 4 years ago

THANKS!! it was that. Now works great!