search

torgeadelin / react-native-animated-nav-tab-bar

A simple and customisable React Native component that implements an animated bottom tab bar for React Navigation.
MIT License
893 stars 101 forks source link

keyboardHidesTabBar doesn't work #63

Closed ranuwp closed 3 years ago

ranuwp commented 3 years ago

Whenever the keyboard appears, the tab bar will still there and hides the input for keyboard

torgeadelin commented 3 years ago

Does this happen on ios or android? If it is an actual issue, it's most likely due to react-navigation.

papidb commented 3 years ago

Hey, it happens on android, not ios. Tried passing in keyboardHidesTabBar: true into tabBarOptions but it doesn't work. Is there a fix for this?

m-ruhl commented 3 years ago

@torgeadelin

I can confirm the issue. When I use "@react-navigation/bottom-tabs" the tabbar is hidden. When using this framework it looks like this bottomBar

papidb commented 3 years ago

So I was able to come up with a very buggy fix. https://github.com/benjamin-daniel/react-native-animated-nav-tab-bar/tree/bug/keyboardHidesOnTab will still take a look at it. I heavily copied https://github.com/react-navigation/react-navigation/tree/main/packages/native. Check it out if you are free! @m-ruhl @torgeadelin

hillkim commented 3 years ago

@papidb Why cant you create a PR for this? Can I do it?

papidb commented 3 years ago

Yeah, you can. I don't mind, but like I said it is very rough, you can try to tidy it up. Thanks.

mahmoudshaeerhomzmart commented 2 years ago

++