Remove the remaining hardcoded game type names

[torhus]

Just keep the default Q3 ones. This requires an update of mods.ini.

[torhus]

Suggested procedure:

• Add the missing ones in the next release
• In the release after that, remove the hardcoded ones
  • Then overwrite mods.ini if SG and Padman does not have gameType set

[The-Gig]

  * Then overwrite mods.ini if SG and Padman does not have gameType set

Do you mean replacing the whole mods.ini (potentially wiping out users custom settings for all games) or search text to detect the Padman section and just add a line under it?

[torhus]

I mean replacing it, like it did when I released 0.9e, wish I would have done this too then. But I suppose I could just do a search and replace instead.

[The-Gig]

I don't know how people are used to update Monster Browser without losing their configuration, as I've always used the "portable" version and extracted each beta in a new folder and re-done the few changes to set the Quake3 and OpenArena paths...

I guess one might manually copy elsewhere his .ini files and then copy them over the one which comes with the new version, but in that case one would not get the updates to the .ini file which may have come with it.

[torhus]

The installer doesn't overwrite mods.ini, but MB itself can do it. I have only used this functionality for a couple of releases, I expect it annoys users. If you edit settings.ini to set programVersion to something older than 0.9e, MB will overwrite mods.ini the next time you start it. The previous time it was used was for 0.8a.

[The-Gig]

Oh. Is any kind of warning provided to users? If it's done silently, with no opt-out nor warning, I can see people being upset...

[torhus]

You just get a message that your config file was backed up and replaced.

[torhus]

I'm thinking about just removing the hardcoded game type names, and adding this to the end of the change log instead of trying to update the configuration:

Note: If you are updating MB, and wish to keep seeing the correct game type names for Smokin' Guns and World of Padman, you have to add these lines to their respective configuration sections: For SG: gameTypes=FFA Duel 2 TDM RTP BR For WoP: gameTypes=FFA 1v1 2 SyC LPS TDM CtL SyCT BB

[The-Gig]

I noticed that Defrag and RA3 configurations don't have the gameType line set (MB 0.9i). I thought those mods did have some custom gametypes...

[torhus]

I noticed that Defrag and RA3 configurations don't have the gameType line set (MB 0.9i). I thought those mods did have some custom gametypes...

Right, I should probably check that out...

[The-Gig]

I just tried to check Defrag documentation, and it looks like they use their own cvar: df_gametype. https://www.q3df.org/wiki?p=174 https://www.q3df.org/wiki?p=196 Which means no luck for us, I guess...

I'm from cell phone st the moment, I can't check now what Defrag servers do have in their classic g_gametype cvar.

[torhus]

Ok, I wonder why they added a new cvar...

Rocket Arena servers all run game type 8, maybe there is only the one?

[The-Gig]

Years ago, here https://openarena.fandom.com/wiki/ModCompat/Rocket_Arena_3 we mentioned that the custom RA3 gametypes were Rocket Arena, Clan Arena, Red Rover Arena, Practice Arena. But I guess I need to do some deeper research when I have time.

[The-Gig]

I downloaded RA3 and yes, it looks like g_gametype is always 8 despite which of the four modes you are playing. It does not even need to reload the map to change mode, it seems. So, just showing gametype 8 seems to be right thing to do (apart maybe some trick to show it blank instead?)...