toriato / stable-diffusion-webui-wd14-tagger

Labeling extension for Automatic1111's Web UI
1.34k stars 235 forks source link

[Bug/Feature] Windows path \ support in Batch dialog #20

Closed Evil-Dragon closed 1 year ago

Evil-Dragon commented 1 year ago

Please don't hate me but i'm using this extension a lot so it's become a daily driver in my dreambooth'ing process.

The input box in batch process only accepts using / (forward slash) in paths which when you're copying and pasting Windows paths becomes a bit of a pain to change them all, especially in longer paths with many subdirectories. Is it possible to support using \ (back slash) in the dialog input?

Also might be worth dropping the * at the end of the path and intergrating it into the code by default. Chances are users will want every image file in the path will be processed nearly 99% of the time in most use cases.

Thank you for all your work and coding on this great extension. I hope more people are using it than just me and would love to see other people suggest more features/suggestions in future.

toriato commented 1 year ago

I don't hate you! Rather, I'm thankful that you use my extension a lot and post a lot of good ideas. I'm rather sorry for not answering or being late because I'm a little busy. If there are any inconveniences while using it, please feel free to open the issue!

toriato commented 1 year ago

The input box in batch process only accepts using / (forward slash) in paths

I will test this part in the Windows environment, thank you for letting me know!

Also might be worth dropping the * at the end of the path and intergrating it into the code by default. Chances are users will want every image file in the path will be processed nearly 99% of the time in most use cases.

https://github.com/toriato/stable-diffusion-webui-wd14-tagger/blob/aa51c991b9bdf4d1a956f195aa642194222dc424/scripts/tagger.py#L307-L311

This part already works as you said, if there is no pattern in the received path, it will be added automatically, so you don't have to put it in.

Evil-Dragon commented 1 year ago

Marking as closed since this now works with the latest versions of the tagger.