torifat / xiaomi-mi-air-purifier

Homebridge plugin for Xiaomi Mi Air Purifier
Apache License 2.0
99 stars 15 forks source link

Move to node-mihome from miio #19

Open torifat opened 3 years ago

torifat commented 3 years ago

Currently, I'm using a fork of miio where support for miot devices were added. It's really hard to add support for new devices without owning them. I found node-mihome project which seems a lot more feature complete with more device support.

malditavibora commented 3 years ago

Hi torifat, do you think you will be able to implement the support for the 3C model due to the API changes? Let me know if I can help on testing it.

ifeign commented 3 years ago

Hi torifat, do you think you will be able to implement the support for the 3C model due to the API changes? Let me know if I can help on testing it.

Probably, it's in the node-mihome supported devices list.

Screen Shot 2021-01-18 at 4 12 10 PM
malditavibora commented 3 years ago

Hi Torifat, the mb3 model belongs to the Air Purifier 3H, the 3C model is the mb4 and this one is not in the list.

malditavibora commented 3 years ago

the node-mihome is not a Homebridge plugin right? not sure how to add this under Homebridge. Sorry I'm new in this world.

torifat commented 3 years ago

@danixque no, it's not a homebrige plugin. It's a library for controlling devices. If I move to it then I will be able to support all the devices. I spent some time recently exploring it. The main problem is it works a bit differently. For example, you need to give it your xiaomi username and password. It uses that to pull your list of devices and generate token. My concern is some people might not be happy to provide their username and password.

malditavibora commented 3 years ago

Is the node-mihome library a way of testing some devices in order to be able to create a Homebridge plugin after the investigation? Is this a good place to run the mihome code https://npm.runkit.com/node-mihome ? Should I post the console results somewhere?

adamrzanek commented 3 years ago

Is it gonna be online only solution? I have disabled internet connection on my xiaomi devices. So it will not work for me i think

ifeign commented 3 years ago

I don't think any of the mi purifier plugins out there work without internet access.. or am I missing something?

On Thu, Jan 21, 2021 at 12:11 AM adamrzanek notifications@github.com wrote:

Is it gonna be online only solution? I have disabled internet connection on my xiaomi devices. So it will not work for me i think

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-764460412, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHWLHYFWIG5RA6PTJIFKXGLS27OT5ANCNFSM4VWWAO3Q .

adamrzanek commented 3 years ago

They all work without internet :) i have no internet access set on homebridge and all xiaomi devices and it’s all working good

On 22 Jan 2021, at 20:36, ifeign notifications@github.com wrote:

 I don't think any of the mi purifier plugins out there work without internet access.. or am I missing something?

On Thu, Jan 21, 2021 at 12:11 AM adamrzanek notifications@github.com wrote:

Is it gonna be online only solution? I have disabled internet connection on my xiaomi devices. So it will not work for me i think

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-764460412, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHWLHYFWIG5RA6PTJIFKXGLS27OT5ANCNFSM4VWWAO3Q .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

ifeign commented 3 years ago

Which plugin are you using? I've been using this one and it doesn't seem to work offline https://github.com/YinHangCode/homebridge-mi-airpurifier

On Fri, Jan 22, 2021 at 11:41 AM adamrzanek notifications@github.com wrote:

They all work without internet :) i have no internet access set on homebridge and all xiaomi devices and it’s all working good

On 22 Jan 2021, at 20:36, ifeign notifications@github.com wrote:

 I don't think any of the mi purifier plugins out there work without internet access.. or am I missing something?

On Thu, Jan 21, 2021 at 12:11 AM adamrzanek notifications@github.com wrote:

Is it gonna be online only solution? I have disabled internet connection on my xiaomi devices. So it will not work for me i think

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-764460412 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AHWLHYFWIG5RA6PTJIFKXGLS27OT5ANCNFSM4VWWAO3Q

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-765642169, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHWLHYB4UETK7PLSXPLFA4LS3HIHTANCNFSM4VWWAO3Q .

adamrzanek commented 3 years ago

This one https://github.com/YinHangCode/homebridge-mi-airpurifier for 2h

On 22 Jan 2021, at 23:15, ifeign notifications@github.com wrote:

 Which plugin are you using? I've been using this one and it doesn't seem to work offline https://github.com/YinHangCode/homebridge-mi-airpurifier

On Fri, Jan 22, 2021 at 11:41 AM adamrzanek notifications@github.com wrote:

They all work without internet :) i have no internet access set on homebridge and all xiaomi devices and it’s all working good

On 22 Jan 2021, at 20:36, ifeign notifications@github.com wrote:

 I don't think any of the mi purifier plugins out there work without internet access.. or am I missing something?

On Thu, Jan 21, 2021 at 12:11 AM adamrzanek notifications@github.com wrote:

Is it gonna be online only solution? I have disabled internet connection on my xiaomi devices. So it will not work for me i think

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-764460412 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AHWLHYFWIG5RA6PTJIFKXGLS27OT5ANCNFSM4VWWAO3Q

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/torifat/xiaomi-mi-air-purifier/issues/19#issuecomment-765642169, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHWLHYB4UETK7PLSXPLFA4LS3HIHTANCNFSM4VWWAO3Q .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.