search

torikushiii / hoyolab-auto

Auto check-in and others for any Hoyoverse games
https://ko-fi.com/torikushiii
GNU Affero General Public License v3.0
107 stars 24 forks source link

Change JSONC configuration to JSON5 #39

Closed abigailwillow closed 4 months ago

abigailwillow commented 4 months ago

As @StayBlue mentioned in PR #37 JSON5 might be a better alternative than the proprietary JSONC format I initially chose.

JSON5 is documented much better than JSONC, and the json5 package is maintained better than the jsonc package, which might be relevant as @torikushiii mentioned wanting to avoid third-party modules. A more well-maintained package should be better in this case.

JSON5 may also offer potential improvements for future configuration options, as it is more closely related to ES5, whereas JSONC appears to simply be JSON with comments.

abigailwillow commented 4 months ago

Completed the requested changes.

torikushiii commented 4 months ago

Looks good to me, I'm happy with how it looks.

Thank you so much for your contribution to this project!