search

torikushiii / starrail-auto

Auto check-in and others for Honkai: Star Rail
https://ko-fi.com/torikushiii
GNU Affero General Public License v3.0
106 stars 24 forks source link

Github Actions workflow integration #28

Closed wijayaerick closed 10 months ago

wijayaerick commented 10 months ago

First of all, thank you for implementing this automation. I've been running this for a few months with github action workflow setup.

It'd be nice to have Github Actions integration; people will be able setup their automation by following steps:

  1. Fork repo
  2. Set secrets in the settings
  3. Enable github action workflow

This will be applicable only with --sign flag because the workflow only runs short process.

I'm willing to work on this if it's ok for you.

torikushiii commented 10 months ago

Hi, thank you for your implementation suggestion and work.

But if I recall correctly, using GitHub actions as daily check-in is on gray area as I remember that it's violates against their Terms of Service but I do not remember what exactly.

wijayaerick commented 10 months ago

I'm not sure which ToS you're referring, but I assume it has something to do with the nature of this tool. Thanks for the response, I think we can close this issue.

torikushiii commented 10 months ago

I will try to get some information in the meantime, If I'm wrong I'll reopen this suggestion again.