search

torizon / meta-toradex-torizon

Torizon OS OpenEmbedded Distro Layer
MIT License
6 stars 10 forks source link

torizon.inc: remove BBMASK from meta-freescale/cairo append #12

Closed leonheldattoradex closed 3 months ago

leonheldattoradex commented 5 months ago

Having this BBMASK makes it impossible to have DISTRO_FEATURES such as x11 or wayland on iMX8, which is an issue for users of torizon-minimal.

As the append is imxgpu-specific, it shouldn't affect any other machines. It also shouldn't affect the other torizon builds as no package from those depends/requires cairo.

MingliuYan commented 5 months ago

Hi, @leonheldattoradex

I added that because when "PACKAGECONFIG:append:imxgpu3d = " egl glesv2"" being enabled in meta-freescale/recipes-graphics/cairo/cairo_%.bbappend, it requires "opengl" in DISTRO_FEATURES, which torizon distro does not satisify that, then we got bitbake errors. But that was very long time ago in thud branch, maybe that distro check has been removed in kirkstone.

I think it should fine by removing that if the following builds OK:

MACHINE=apalis-imx8 bitbake torizon-core-docker
MACHINE=colibri-imx7 bitbake torizon-core-docker
MACHINE=qemuarm64 bitbake torizon-core-docker
MingliuYan commented 5 months ago

@leonheldattoradex @jsrc27

I have made https://github.com/torizon/meta-toradex-torizon/pull/17, I think this PR could be merged together with it.

leonheldattoradex commented 5 months ago

@EdTheBearded @jsrc27 I've rebased after #17. Let me know if you want to merge this or close it.

EdTheBearded commented 5 months ago

@leonheldattoradex have you tested the machines suggested by Ming?