search

torizon / meta-toradex-torizon

Torizon OS OpenEmbedded Distro Layer
MIT License
6 stars 10 forks source link

python3-bcrypt patching fails with TC 6.5.0 #24

Open jm-amt opened 5 months ago

jm-amt commented 5 months ago

0001-setup.py-drop-cffi-from-requirements.patch fails when building TC 6.5.0. It seems like the patch is targeting the 3.1.7 bcrypt version in the OE dunfell release, however python3-bcrypt version is 3.2.0 in kirkstone.

The setup.py has changed between these versions, hence the failed patching.

MingliuYan commented 5 months ago

@jm-amt Hi,

We are maintaining quite some patches for python3 modules:

./recipes-devtools/python/python3-bcrypt
./recipes-devtools/python/python3-requests_%.bbappend
./recipes-devtools/python/python3-urllib3
./recipes-devtools/python/python3-urllib3_%.bbappend
./recipes-devtools/python/python3-nacl
./recipes-devtools/python/python3-bcrypt_%.bbappend
./recipes-devtools/python/python3-nacl_%.bbappend
./recipes-devtools/python/python3-cffi_%.bbappend
./recipes-devtools/python/python3-dotenv_%.bbappend
./recipes-devtools/python/python3-docker_%.bbappend
./recipes-devtools/python/python3-jsonschema_%.bbappend
./recipes-devtools/python/python3_%.bbappend
./recipes-devtools/python/python3-requests
./recipes-devtools/python/python3
./recipes-devtools/python/python3-docker

they were introduced to get python3-docker-compose run faster, which is a long time ago, when we were still using python3-docker-compose, since now we have changed to use docker compose V2, maybe we shall consider clean these patches?

jm-amt commented 5 months ago

If they are indeed no longer used (which seems like why errors aren't picked up by the regular torizon-core builds) then personally I would remove them. Less work for anyone needing python3-bcrypt so they don't have to remove the patches themselves.