Closed rborn-tx closed 1 month ago
Wow, quite a list!
To be fair, I just did a glance over and if it's all building fine then awesome! :grinning:
But about you last 2 commits, on making RAC build. We have an internal ticket that we were discussing the actual fix. Thinking of it, the commit you proposed seems better for us, on a maintenance point of view, but I've asked the Cloud team if there's any downsides to this. So I'm just waiting their answer to approve this!
@leograba, can we please schedule the branch out ticket as soon as this PR is merged?
@leograba, can we please schedule the branch out ticket as soon as this PR is merged?
@EdTheBearded, sure.
Just a warning: everything was a single ticket originally to do both the update and the branch out. It was split for some reason I don't recall exactly why. Perhaphs @rborn-tx remember the reasoning behind it. My point being, do we really want to branch out as soon as this PR is merged?
@leograba yes, branching out now we don't miss the work done here, and we start leveraging the automated testing we have. This way we can start our Jenkins matrix on Scarthgap, which will also check for the signed builds, as well as start generating LAVA reports.
@rborn-tx Seems we're good to go with this merge.
I'd like to just ask you if you could change, on rac_git.bb
, the comment where we replace --frozen
for --offline
to explain the actual reason, since this won't be a temporary fix. Maybe something like
Due to the changes we needed to do in RAC Yocto recipe in order to use our toradex/tough registry, tough repository got sort of aliased, so the upstream git URL was in fact referencing our toradex/tough fork. And since this is a hack on top of Cargo, it got somewhat lost while parsing Cargo.lock and thought that the repository there needed to change to the upstream one to reflect the state of things.
@EdTheBearded
I'd like to just ask you if you could change, on
rac_git.bb
, the comment where we replace--frozen
for--offline
to explain the actual reason, since this won't be a temporary fix.
Done
Awesome, thanks @rborn-tx!
Here is the list of commits in kirkstone that were not present in master and their status once this PR is merged:
The commits with status "Applied" that required non-trivial changes to solve conflicts were signed by myself besides the original sign-off.
The following build configurations were tested (build only):
At the time of writing build for the verdin-imx8mm were failing due to QA error on package
firmware-imx
; in order for the build to succeed I disabled the specific QA check by doing:Hopefully this will be fixed upstream soon.