Remove setrosmaster call due to the change in upstream.

tork-a / baxter_seminar

Seminar sourcecode for the Baxter (Research) Robot from Rethink Robotics

4 stars 5 forks source link

Remove setrosmaster call due to the change in upstream. #17

Closed 130s closed 9 years ago

130s commented 9 years ago

DO NOT MERGE YET.

Doing what https://github.com/tork-a/baxter_seminar/commit/953cc72aa3036b21251589f1c52e42f452550798#diff-09bf2ce9eb6a646a9603e9899ee973adR5 suggests to do. Not sure if this correct, but I don't find command setrosmaster.

130s commented 9 years ago

Commit modified; I noticed that jsk_tools already has rossetmaster so the following single line is enough for setting ros master:

$ rossetmaster 011402P0006.local

130s commented 9 years ago

May not be good enough yet:

$ rosrun baxter_seminar_helper seminar.sh 
set ROS_MASTER_URI to http://011402P0006.local:11311
set ROS_IP and ROS_HOSTNAME to 192.168.11.6
/opt/ros/indigo/share/jsk_tools/src/bashrc.ros: line 60: rossetrobot: command not found
$ dpkg -p ros-indigo-jsk-tools | grep Version
Version: 1.0.58-0trusty-20150107-1727-+0000

(I know we're supposed to use hydro though.)

130s commented 9 years ago

Ok, we can't yet merge this since jsk_tools isn't publicly synchronized yet.

130s commented 9 years ago

Closing in favor of https://github.com/tork-a/baxter_seminar/pull/20