search

tork-a / jog_control

Apache License 2.0
55 stars 18 forks source link

Implemented a twist_to_jogframe controller #39

Closed lit-af closed 4 years ago

lit-af commented 4 years ago

This PR has had a code review on our end.

7675t commented 4 years ago

Thanks for your contribution. Iā€™ļ½ checking them in a few days.

7675t commented 4 years ago

Thanks for your contribution. I understand this PR for SpaceNav (Unfortunately I don't have it).

Are these are correct?

I have no problem to merge this. Please fix the dependency to pass the CI.

lit-af commented 4 years ago

Thanks for your contribution. I understand this PR for SpaceNav (Unfortunately I don't have it).

Are these are correct?

  • SpaceNav produce joy AND twist message
  • Current joy_to_jog_frame.py frame is not enough to control the robot with SpaceNav
  • So you add twist_to_jog_frame.py to control your robot with SpaceNav
  • You have confirmed you can control your robot with it, and you are totally happy šŸ˜„

I have no problem to merge this. Please fix the dependency to pass the CI.

Yes to all of the above. Tested it using the simulated motoman_sia20d robot.

lit-af commented 4 years ago

@7675t Weird, that travis-ci couldn't compile this PR as I'm running on ubuntu 18.04

7675t commented 4 years ago

@LazyEngineerToBe Don't worry about it fails in melodic. It needs some package released.