search

torkiljohnsen / swipe

jQuery plugin that adds mobile touch swipe event handling, and allows for vertical scrolling.
http://torkiljohnsen.com/demo/layered-mobile-nav/
183 stars 17 forks source link

Updated pull request #31

Closed gregstewart closed 12 years ago

gregstewart commented 12 years ago

I have gone ahead and merged the different framework files into one called pageswipe.js. I then added grunt.js to jslint and minify the files (I fixed up the warnings in jquery.-, zepto.- and the merged file). The output is now stored in dist/ and I have updated the demos to point to the dist folder.

Hope this all makes sense.

Cheers Greg

torkiljohnsen commented 12 years ago

Nice! Perhaps grunt.js could be added as a submodule instead of copy-pasting it directly in here?

gregstewart commented 12 years ago

Do you mean create a folder for the grunt.js file, e.g. build/ and run it from there?

torkiljohnsen commented 12 years ago

Yes. Instead of copy/pasting grunt into the repo, keeping it up to date manually, we just store a reference here to it's GitHub repo. For instance in vendors/grunt/

torkiljohnsen commented 12 years ago

vendors/ is nice and general, so that if we want to add other stuff in the future, like for instance hammer.js (http://eightmedia.github.com/hammer.js/), there's already a place for that :)

gregstewart commented 12 years ago

OK I have moved the grunt.js file into a vendor/grunt folder, I'll open another pull request