search

tormoder / fit

A Go package for decoding and encoding Garmin FIT files
MIT License
243 stars 42 forks source link

Initial writer support #34

Closed usedbytes closed 5 years ago

usedbytes commented 5 years ago

Implements support for encode, with some known limitations (e.g. #36, #37)

Fixes #1

usedbytes commented 5 years ago

The first commit is necessary for me, otherwise fitgen segfaults. I'm not sure why I'm seeing it if you aren't, but I think it should be harmless.

usedbytes commented 5 years ago

Thanks for the review! All the comments make sense, I'll send a respin with them fixed.

In the process of implementing your suggestions, though, I've found that the DecodeEncodeDecode test wasn't really doing anything after a last minute change, because I return instead of continue on skipped files. Now I'm seeing some bugs related to Array handling - so I'll fix that up first.

I'm about to go away for a couple of weeks, but I will try to get the update pushed while I'm travelling.

usedbytes commented 5 years ago

So it wasn't as bad as I thought. I had to "blacklist" a couple more files in the round-trip test, but there's still 12 files which get run through it. I opened #36 and #37 for the major limitations, and tagged the skipEncodes with those issue numbers where appropriate.

I added some text to the merge message at the top, I hope that works. I've not done many Github pull requests before :smile:

tormoder commented 5 years ago

Great, thank you for writing the down the limitations.

I'll merge this and tag a 0.4.0 release soon.

Thanks again!