Add support for large messages

tormoder / fit

A Go package for decoding and encoding Garmin FIT files

MIT License

245 stars 42 forks source link

Closed bpg closed 3 years ago

bpg commented 3 years ago

Fix implicit type conversion in reader that caused byte overflow when number of fields in definition message in >85.
Add real life fit activity to the test suite to replicate the problem
Fix definition message creation logic in writer -- now it scans all records of specific type to find all fields that have valid values to build a definition message.

This fixes #43, and fixes #53

tormoder commented 3 years ago

@bpg Thanks for digging into this.

I'll try to take a look as soon as possible.

tormoder commented 3 years ago

Sorry for the delay...

Thanks for spotting the overflow.

Suggestion, could we just remove the maxFieldSize constant? And just set the array length for tmp to 255 * 3 directly?

bpg commented 3 years ago

Thanks, updated!